Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles to guide pages #65

Merged
merged 3 commits into from Jun 27, 2018
Merged

Add titles to guide pages #65

merged 3 commits into from Jun 27, 2018

Conversation

@meven
Copy link
Contributor

@meven meven commented Jun 16, 2018

I am the kind of person that opens tons of tabs, and missing proper title is quite inconveninient.

@meven
Copy link
Contributor Author

@meven meven commented Jun 16, 2018

The format of the title could be instead " | Diesel"

Copy link
Owner

@sgrif sgrif left a comment

I'd prefer the | Diesel form. Can we make this a helper?

@@ -1,3 +1,7 @@
---
title: "Diesel - guides"

This comment has been minimized.

@sgrif

sgrif Jun 25, 2018
Owner

Guides should be captialized

@meven
Copy link
Contributor Author

@meven meven commented Jun 25, 2018

I will make this an helper, I need to learn more about middleman, and refresh my ruby knowledge though.
I tried to use middleman-title but it appears to be close to incompatible with slim templates.

@sgrif
Copy link
Owner

@sgrif sgrif commented Jun 26, 2018

I'm fine with just hard coding in that case.

@meven
Copy link
Contributor Author

@meven meven commented Jun 27, 2018

I gave it another try and managed to get it to work quite simply using the layout to append " | Diesel" to pages titles.
Feel free to squash the commits.

@sgrif sgrif merged commit e0f4190 into sgrif:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.