New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles to guide pages #65

Merged
merged 3 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@meven
Contributor

meven commented Jun 16, 2018

I am the kind of person that opens tons of tabs, and missing proper title is quite inconveninient.

@meven

This comment has been minimized.

Show comment
Hide comment
@meven

meven Jun 16, 2018

Contributor

The format of the title could be instead " | Diesel"

Contributor

meven commented Jun 16, 2018

The format of the title could be instead " | Diesel"

@sgrif

I'd prefer the | Diesel form. Can we make this a helper?

Show outdated Hide outdated source/views/guides/index.html.slim Outdated
@meven

This comment has been minimized.

Show comment
Hide comment
@meven

meven Jun 25, 2018

Contributor

I will make this an helper, I need to learn more about middleman, and refresh my ruby knowledge though.
I tried to use middleman-title but it appears to be close to incompatible with slim templates.

Contributor

meven commented Jun 25, 2018

I will make this an helper, I need to learn more about middleman, and refresh my ruby knowledge though.
I tried to use middleman-title but it appears to be close to incompatible with slim templates.

@sgrif

This comment has been minimized.

Show comment
Hide comment
@sgrif

sgrif Jun 26, 2018

Owner

I'm fine with just hard coding in that case.

Owner

sgrif commented Jun 26, 2018

I'm fine with just hard coding in that case.

@meven

This comment has been minimized.

Show comment
Hide comment
@meven

meven Jun 27, 2018

Contributor

I gave it another try and managed to get it to work quite simply using the layout to append " | Diesel" to pages titles.
Feel free to squash the commits.

Contributor

meven commented Jun 27, 2018

I gave it another try and managed to get it to work quite simply using the layout to append " | Diesel" to pages titles.
Feel free to squash the commits.

@sgrif sgrif merged commit e0f4190 into sgrif:master Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment