New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just doesn't work #78
Comments
Check your log. NametagEdit disables itself if it finds it is incompatible with your server version. There is an important error it will print. |
|
Please post your groups.txt. Keep in mind you are using an ancient version of NametagEdit that is no longer supported. |
But I got it from the dev site: http://ci.playmc.cc/job/NametagEdit/42/artifact/target/NametagEdit.jar It's build 42. |
@sgtcaze And I do not understand why it says I have v2.4 and tells me that a newer version is available (v2.4). |
In your previous message it says
Build 42 of NametagEdit is revision 4.1.1. Anyway, is 4.1.1 working for you? (2.4 is over 2 years old) |
@sgtcaze Ok so I fixed the formatting of groups.txt and the prefixes still aren't showing up. My log was spammed with tons of errors though:
|
4.1.1. NametagEdit does not use groups.txt or players.txt anymore. It uses groups.yml and players.yml. Your error hints to me that the Packet class cannot be loaded. Can you send me a link to the jar file you're using? |
@sgtcaze Well in the NameTagEdit folder there are the groups.yml and players.yml files. It also generates the groups.txt and players.txt files too. |
@sgtcaze Ok, I reinstalled NametagEdit and I got a newish error in my log:
|
I asked you for a link to your server jar. Please send it so I can help you further. |
If you mean Thermos: Jar: https://github.com/CyberdyneCC/Thermos/releases/download/57/Thermos-1.7.10-1614-server.jar Required libs: https://github.com/CyberdyneCC/Thermos/releases/download/57/libraries.zip |
I'll try to get back to you soon. Problem with Cauldron/Derivatives is that they compile NMS classes and proxy them on the fly. Meaning, that it makes it hard to write code that anticipates that. |
Ah I see. Looking forward to hearing back! |
I regret to inform you that at this time I do not believe we will be able to support Thermos. I did a lot of digging for the past few hours and do not think we can reliably support it. NametagEdit relies on 4 direct NMS Classes:
I was able to find the first 3:
I was unable to find the PlayerConnection class equivalent. I was able to locate a necessary Craftbukkit class, however.
And I tried to go backwards by using getHandle(), which gave me a class with type:
I tried scanning for a method/field which will enable me to send the Packet class (which is named "nh" in the default package of server-1.7.10.jar). Again I wasn't lucky in finding it. All I need in order to provide compatibility is to figure out what the PlayerConnection class equivalent is. Forge help questions weren't very helpful, unfortunately. Also I need to know where they're proxying that sendPacket method. |
MiniUpdate
With the name:
|
Update 3: |
@sgtcaze wait if you were able to find what the PlayerConection equivalent is, then what's the issue? |
@sgtcaze and what do you mean by it being a forge module? |
I was still unable to find the sendPacket equivalent from the Packet interface. The problem is forge and derivatives use ASM to remap classes and proxy them. The same is true for methods and fields. Because of these remappings I cannot reliably reflect into specific fields because the names change. The only reliable way is to compile with forge. Though it would take a rewrite of the plugin to abstract the packet handler and methods. |
Ah damn. Well thank you so much for looking into this in depth! |
@sgtcaze Do you happen do know any other equivalents that will work with a Thermos/KCauldron/Forge server? |
Do you intend on using scoreboards? With the default bukkit api you can create scoreboard teams. The downside is, if there are other plugins creating scoreboards, you'll lose the tags. If you don't want the additional prefix/suffix length, you can get away with altering the player's list name. If you want the nametag above the head formatted, you'll need that Scoreboard team packet. I am unaware of any forge plugins that can accomplish this (I don't use forge at all). |
Ah gotcha. Well thanks anyway! |
@sgtcaze I just discovered Colored Tags, and for some reason it does work with Thermos (though it spams the console every time a player logs on and logs off of the server). Its functionality is basically identical to NametagEdit. |
I've tried using the current stable release and the latest dev release and the name tag prefixes just don't show up (neither on top of head nor tab list). I both tried using user groups (PEX) and using the individual prefix edit command and neither worked. I'm running a 1.7.10 Thermos (fork of kCauldron) server.
Thanks!
The text was updated successfully, but these errors were encountered: