Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate werkzeug.contrib.cache #75

Merged
merged 7 commits into from Jul 10, 2018

Conversation

@dchevell
Copy link
Contributor

commented Jul 9, 2018

As per #72 , this PR simply removes the direct dependency on werkzeug.contrib.cache. As a first step, the werkzeug implementation has been adopted wholesale, and the rest of this library simply updated to use the correct import paths and to reflect that in the docs.

Going forward we may want to remove these and replace them with something similar, but as an immediate change to guard against werkzeug.contrib.cache's planned deprecation this PR makes no attempt to change or improve the cache backends themselves.

dchevell added 4 commits Jul 9, 2018
@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2018

Coverage Status

Coverage decreased (-22.0%) to 57.189% when pulling 3a97ed1 on dchevell:master into 039d8ae on sh4nks:master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2018

Coverage Status

Coverage decreased (-10.7%) to 68.432% when pulling 1daebdc on dchevell:master into 039d8ae on sh4nks:master.

@dchevell dchevell force-pushed the dchevell:master branch 2 times, most recently from 631d2cf to b90424f Jul 9, 2018

@dchevell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2018

Adding werkzeug's test for caching backends

@dchevell dchevell force-pushed the dchevell:master branch 2 times, most recently from ae765fa to 1f7360e Jul 9, 2018

@dchevell dchevell force-pushed the dchevell:master branch from 1f7360e to 41afe7a Jul 9, 2018

@dchevell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2018

Apparently pytest deciced to drop support for python3.3 as it is now EOL. This breaks some tests running on py3.3 so I've removed that, and added py37-dev to make sure we're testing the latest release.

@sh4nks
Copy link
Owner

left a comment

Besides the typo in docs/index.rst it looks good to me!

@@ -409,7 +408,7 @@ Relevant configuration values
- CACHE_MEMCACHED_SERVERS


.. note:: Werkzeug does not pass additional configuration options
.. note:: Flask-Cached does not pass additional configuration options

This comment has been minimized.

Copy link
@sh4nks

sh4nks Jul 10, 2018

Owner

Flask-Caching

This comment has been minimized.

Copy link
@dchevell

dchevell Jul 10, 2018

Author Contributor

I wear the cone of shame! I'll fix it now.

@dchevell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2018

Fixed @sh4nks

@sh4nks sh4nks merged commit 5d1856b into sh4nks:master Jul 10, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-10.7%) to 68.432%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sh4nks

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2018

Thanks a lot @dchevell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.