Skip to content
This repository has been archived by the owner. It is now read-only.

Add xmlns attribute to generated SVGs #17

Merged
merged 1 commit into from Dec 23, 2018
Merged

Add xmlns attribute to generated SVGs #17

merged 1 commit into from Dec 23, 2018

Conversation

@ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Dec 22, 2018

Description

All generated icons now have the xmlns="http://www.w3.org/2000/svg" attribute + value on them.

Why is this change required?

tl;dr: since SVG is an XML dialect you should specify its namespace so all rendering engine will properly display the SVG. More here.

  • I've read the contributing guidelines and the Code of Conduct
@codecov
Copy link

@codecov codecov bot commented Dec 22, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          40     40           
  Branches       12     12           
=====================================
  Hits           40     40
Impacted Files Coverage Δ
src/VueSimpleIcon.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28c60a...d5782c7. Read the comment docs.

@ericcornelissen ericcornelissen changed the title fix: add xmlns attribute to generated SVGs Add xmlns attribute to generated SVGs Dec 22, 2018
@sh7dm sh7dm self-requested a review Dec 23, 2018
sh7dm
sh7dm approved these changes Dec 23, 2018
Copy link
Owner

@sh7dm sh7dm left a comment

Cool!

@sh7dm sh7dm merged commit a1a8e6e into master Dec 23, 2018
4 checks passed
4 checks passed
@codecov[bot]
codecov/patch Coverage not affected when comparing b28c60a...d5782c7
Details
@codecov[bot]
codecov/project 100% remains the same compared to b28c60a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sh7dm sh7dm deleted the add-xmlns-attribute branch Dec 23, 2018
@sh7dm sh7dm added this to the First release milestone Dec 23, 2018
@sh7dm
Copy link
Owner

@sh7dm sh7dm commented Dec 23, 2018

@ericcornelissen Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants