New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `xmlns` attribute to generated SVGs #17

merged 1 commit into from Dec 23, 2018


None yet
2 participants
Copy link

ericcornelissen commented Dec 22, 2018


All generated icons now have the xmlns="" attribute + value on them.

Why is this change required?

tl;dr: since SVG is an XML dialect you should specify its namespace so all rendering engine will properly display the SVG. More here.

  • I've read the contributing guidelines and the Code of Conduct

This comment has been minimized.

Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
  Coverage     100%   100%           
  Files           1      1           
  Lines          40     40           
  Branches       12     12           
  Hits           40     40
Impacted Files Coverage Δ
src/VueSimpleIcon.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28c60a...d5782c7. Read the comment docs.

@ericcornelissen ericcornelissen changed the title fix: add `xmlns` attribute to generated SVGs Add `xmlns` attribute to generated SVGs Dec 22, 2018

@sh7dm sh7dm self-requested a review Dec 23, 2018


sh7dm approved these changes Dec 23, 2018

Copy link

sh7dm left a comment


@sh7dm sh7dm merged commit a1a8e6e into master Dec 23, 2018

4 checks passed

codecov/patch Coverage not affected when comparing b28c60a...d5782c7
codecov/project 100% remains the same compared to b28c60a
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@sh7dm sh7dm deleted the add-xmlns-attribute branch Dec 23, 2018

@sh7dm sh7dm added this to the First release milestone Dec 23, 2018


This comment has been minimized.

Copy link

sh7dm commented Dec 23, 2018

@ericcornelissen Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment