Improve text selection between TextArea items in ListView#1
Merged
shaan7 merged 1 commit intoshaan7:improvements/v1from Aug 18, 2023
Merged
Improve text selection between TextArea items in ListView#1shaan7 merged 1 commit intoshaan7:improvements/v1from
shaan7 merged 1 commit intoshaan7:improvements/v1from
Conversation
Owner
|
Hi @nuttyartist , thanks for the PR! I am merging this to a separate branch since the code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks a lot of your code here! It lays the ground for a proof-of-concept for the Block Editor I'm working on for my note-taking app https://github.com/nuttyartist/daino-notes-public. I thought I might share some additional features I implemented.
Note:
selectLineAtPos()function.selectionAreathat tells the delegates wether to be selected when they are rendered into view.Still not implemented (I plan to implment these in my note-taking app):
keyNavigationEnabled, but still need to implement when the user moves the cursor left and right from the start/end respectively.Thanks again, and I hope this can be useful for others.