Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
#502 Change templates set through administration UI #705
Have a nice day !
Hi! Thanks for your contribution!
A few general remarks though:
Why not ? I don't find a good reason for personalise this setting. But why not.
Me not ;-), I consider a name of template like proper name like title of book or music. Is a personal preference and vision, not a rule or law.
Sorry I not precise for CSS, yes they move into tpl folder, and the user.css keep in inc dir for non breaking existing user personalisation.
Ok my bad, I undo this.
I try to fix test tomorrow, now is children time.
Someone might be already using it, and there is no apparent reason to remove this feature.
Maybe, but I was talking about the folder name: all folders are in lower case in Shaarli (well, except in tests). That's not very important, but I'd like to keep consistency.
Good luck with the tests, feel free to ask if you need help.
Hi! I've reviewed your PR and made a bunch of comments to improve it. Nothing major, but it requires attention.