Add markdown_escape setting #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualtam
approved these changes
Feb 27, 2017
tests/Updater/UpdaterTest.php
Outdated
| /** | ||
| * Test updateMethodEscapeMarkdown with nothing to do (setting already set) | ||
| */ | ||
| public function testEscapeMarkdownSettingNothingToDo() |
There was a problem hiding this comment.
should be split in two tests:
- setting previously enabled
- setting previously disabled
This setting allows to escape HTML in markdown rendering or not. The goal behind it is to avoid XSS issue in shared instances. More info: * the setting is set to true by default * it is set to false for anyone who already have the plugin enabled (avoid breaking existing entries) * improve the HTML sanitization when the setting is set to false - but don't consider it XSS proof * mention the setting in the plugin README
ArthurHoaro
force-pushed
the
hotfix/markdown-html
branch
from
d8941c5 to
e037610
Compare
|
Updated and rebased. |
virtualtam
approved these changes
Mar 1, 2017
|
EDIT:
EDIT 2:
|
virtualtam
added a commit
to virtualtam/Shaarli
that referenced
this pull request
Mar 8, 2017
Adapted from shaarli#785 Signed-off-by: VirtualTam <virtualtam@flibidi.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting allows to escape HTML in markdown rendering or not.
The goal behind it is to avoid XSS issue in shared instances.
More info:
(avoid breaking existing entries)
This need to be backported and released in v0.7.x and v0.8.x.
This PR is high priority.