Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when using ReactElements in first-order types #285

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@baank
Copy link
Contributor

commented Jul 21, 2019

No description provided.

@shadaj

This comment has been minimized.

Copy link
Owner

commented Jul 21, 2019

Looks like the build is failing due to incompatibility with 2.13? Will take a detailed look ASAP.

@shadaj
Copy link
Owner

left a comment

First pass. I'm not super sure if we should be dealing with so many types right now. The main pain points are when using sequences and options, so maybe we should consider just providing conversions for those to start.

core/build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
core/src/main/scala/slinky/core/facade/React.scala Outdated Show resolved Hide resolved
core/src/main/scala/slinky/core/facade/React.scala Outdated Show resolved Hide resolved
core/src/main/scala/slinky/core/package.scala Outdated Show resolved Hide resolved

@shadaj shadaj force-pushed the shadaj:master branch from eb89c01 to 959c47e Aug 17, 2019

@shadaj

This comment has been minimized.

Copy link
Owner

commented Aug 17, 2019

Could you merge with master? I recently switched the CI to GitHub Actions, looks like it doesn't run unless the configuration is present in your branch.

@baank baank force-pushed the harana:master branch from b56eeed to e3437e2 Aug 17, 2019

@shadaj

This comment has been minimized.

Copy link
Owner

commented Aug 17, 2019

Ah, the build docs failure is my mistake. I'll get that fixed in a bit.

@baank baank force-pushed the harana:master branch from e3437e2 to cb91a76 Aug 17, 2019

baank pushed a commit to harana/slinky that referenced this pull request Aug 17, 2019

@baank baank force-pushed the harana:master branch from cb91a76 to b346bf6 Aug 17, 2019

@baank

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

I have cleaned up the Git history so it aligns with existing style.

@shadaj
Copy link
Owner

left a comment

Just a couple more changes, but almost there! Will need a rebase again to fix the bundlesize CI failures.

docs/public/docs/installation.md Outdated Show resolved Hide resolved
tests/build.sbt Outdated Show resolved Hide resolved
core/src/main/scala/slinky/core/facade/React.scala Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved

@baank baank force-pushed the harana:master branch from b346bf6 to 602f33d Aug 18, 2019

@shadaj
shadaj approved these changes Aug 18, 2019
Copy link
Owner

left a comment

Looks good, thanks for this awesome improvement!

@shadaj shadaj merged commit cc9d534 into shadaj:master Aug 18, 2019

7 of 9 checks passed

test
Details
build-docs
Details
build-intellij-plugin
Details
publish
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.