Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move router and history out of docs into main #305

Merged
merged 5 commits into from Jan 8, 2020

Conversation

@zakpatterson
Copy link
Contributor

zakpatterson commented Jan 7, 2020

Add the react-router and html5 history api to the web project

Also add macro settings to web project, for this to work

Add macro settings to web project, for this to work
## To make a commit, type your commit message and press CTRL-ENTER.
## To cancel the commit, close the window. To sign off on the commit,
## press CTRL-S.
##
## You may also reference or close a GitHub issue with this commit.
## To do so, type `#` followed by the `tab` key.  You will be shown a
## list of issues related to the current repo.  You may also type
## `owner/repo#` plus the `tab` key to reference an issue in a
## different GitHub repo.

 build.sbt                                                            | 3 ++-
 {docs => web}/src/main/scala/slinky/history/History.scala            | 0
 {docs => web}/src/main/scala/slinky/reactrouter/ReactRouterDOM.scala | 0
 3 files changed, 2 insertions(+), 1 deletion(-)
@shadaj

This comment has been minimized.

Copy link
Owner

shadaj commented Jan 8, 2020

Thanks for the PR @zakpatterson! The web module is supposed to be just the bindings to ReactDOM and the tags API, so could you move the router facades into another subproject with name := "slinky-react-router"? Then the published name would line up with other facades like slinky-styled-components.

@zakpatterson

This comment has been minimized.

Copy link
Contributor Author

zakpatterson commented Jan 8, 2020

Ok, think that's good. Let me know what you think. Hopefully this helps people a little; I was just copying the router/history code from the docs into my project.

@zakpatterson zakpatterson force-pushed the zakpatterson:feature-add-reactrouter branch from 77652b2 to a4084d7 Jan 8, 2020
Copy link
Owner

shadaj left a comment

Just two small changes, but otherwise LGTM!

reactrouter/build.sbt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shadaj
shadaj approved these changes Jan 8, 2020
@shadaj shadaj merged commit d5ab8cf into shadaj:master Jan 8, 2020
9 checks passed
9 checks passed
test
Details
build-docs
Details
build-intellij-plugin
Details
publish
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
deploy/netlify Deploy preview ready!
Details
@zakpatterson zakpatterson deleted the zakpatterson:feature-add-reactrouter branch Jan 8, 2020
@shadaj shadaj added this to the v0.6.4 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.