Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and testing in Windows #308

Merged
merged 6 commits into from Jan 9, 2020
Merged

Conversation

@nartamonov
Copy link
Contributor

nartamonov commented Jan 8, 2020

Fixed build in Windows OS. I think it will be helpful since not all contributors use Linux for development. I also added standalone job to CI workflow for testing in Windows, but left publication stage not dependent on it. Currently Windows tests works as simple "health" indicator but do not block anything in CI pipeline.

@nartamonov nartamonov marked this pull request as ready for review Jan 8, 2020
Copy link
Owner

shadaj left a comment

This is super awesome @nartamonov! Just one nit but otherwise looks good to go!

)
}

def escapeBackslashes(path: String): String =

This comment has been minimized.

Copy link
@shadaj

shadaj Jan 8, 2020

Owner

Nit: curlies around method body

This comment has been minimized.

Copy link
@nartamonov

nartamonov Jan 9, 2020

Author Contributor

Done. I also rebased changes onto master to resolve conflicts.

@nartamonov nartamonov force-pushed the nartamonov:fix-windows-build branch from 3c111b7 to fe91718 Jan 9, 2020
@nartamonov nartamonov requested a review from shadaj Jan 9, 2020
@shadaj
shadaj approved these changes Jan 9, 2020
Copy link
Owner

shadaj left a comment

LGTM, thanks again for the PR @nartamonov!

@shadaj shadaj merged commit 50e7c38 into shadaj:master Jan 9, 2020
10 checks passed
10 checks passed
test
Details
test-windows
Details
build-docs
Details
build-intellij-plugin
Details
publish
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.