Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA role attribute #309

Merged
merged 2 commits into from Jan 15, 2020
Merged

Add ARIA role attribute #309

merged 2 commits into from Jan 15, 2020

Conversation

@nartamonov
Copy link
Contributor

nartamonov commented Jan 8, 2020

According to HTML 5.2:

Every HTML element may have an ARIA role attribute specified. This is an ARIA Role attribute as defined by [wai-aria-1.1].

The attribute, if specified, must have a value that is a set of space-separated tokens; each token must be a non-abstract role defined in the WAI-ARIA specification [wai-aria-1.1].

@nartamonov nartamonov force-pushed the nartamonov:add-role-attribute branch 2 times, most recently from 5dcd8f0 to ae5a892 Jan 8, 2020
@nartamonov nartamonov marked this pull request as ready for review Jan 9, 2020
@nartamonov nartamonov force-pushed the nartamonov:add-role-attribute branch from ae5a892 to 7a7251b Jan 9, 2020
@shadaj
shadaj approved these changes Jan 15, 2020
Copy link
Owner

shadaj left a comment

LGTM, thanks for the PR @nartamonov!

@shadaj shadaj merged commit dabf670 into shadaj:master Jan 15, 2020
10 checks passed
10 checks passed
test
Details
test-windows
Details
build-docs
Details
build-intellij-plugin
Details
publish
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
deploy/netlify Deploy preview ready!
Details
@shadaj shadaj added this to the v0.6.4 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.