Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style prop to ScrollView, as already available for View #324

Closed
wants to merge 11 commits into from

Conversation

@mcallisto
Copy link
Contributor

mcallisto commented Jan 30, 2020

For now I have added only the style prop.

Please let me know if the other inherited props from View, see
https://facebook.github.io/react-native/docs/scrollview
must be added as well. And, if yes, if there is a better and drier way than just copy paste.

@shadaj shadaj added this to the v0.6.4 milestone Jan 31, 2020
@shadaj shadaj force-pushed the shadaj:master branch from 3d85f66 to b66eca0 Jan 31, 2020
@mcallisto mcallisto mentioned this pull request Jan 31, 2020
@shadaj

This comment has been minimized.

Copy link
Owner

shadaj commented Feb 3, 2020

@mcallisto thanks for the PR! Yeah, it would be great to add the other inherited props too. Unfortunately, there's no way to merge the properties of two case classes together into a new case class so everything will just have to be copied over.

@mcallisto

This comment has been minimized.

Copy link
Contributor Author

mcallisto commented Feb 3, 2020

so everything will just have to be copied over.

Done, thank you @shadaj

Copy link
Owner

shadaj left a comment

Code looks great! Could you add a line to the changelog for this? Also will need a rebase and format since the scalafmt PR was merged.

joan38 and others added 9 commits Jan 30, 2020
* [WIP] Add support for Scala.js 1.0-RC2

* Only test Scala.js React interop for 0.6

* Fix warnings in native tests

* Bump jsdom plugin version

* Try to fix native/vr linker config

* Use Node.js env for native

* Fix native mock render module path

* Restore upgraded interop version

* Fix warnings in interop tests

* Mark interop tests as needing jsdom

* Use NPM instead of WebJars

* Update changelog

* Update testing instructions
* Introduce Scalafmt

* Apply formatting
@mcallisto

This comment has been minimized.

Copy link
Contributor Author

mcallisto commented Feb 4, 2020

Formatted, updated changelog and tried to rebase, but probably messed this last part.
It this PR is unusable, as I fear, just let me know: I will close this and put everything in a new one.

@shadaj

This comment has been minimized.

Copy link
Owner

shadaj commented Feb 4, 2020

Yeah, probably needs a history rewrite (either within this PR or a new one). Perhaps just cherry-picking the original commits onto the latest master would work?

@mcallisto mcallisto closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.