Submissions to /docs/proposals/ - considered Slang Proposed Features (SPFs), and require two Language - Owners (more info + href="https://github.com/shader-slang/spec/tree/master/proposals">/proposals/ in the spec repository + are considered Slang Proposed Features (SPFs), and require a Language + Owner (more info below) to approve the submission.
-- Every file in the Slang repository has a list of owners. An owner of a directory has the right to - approve pull requests - touching the directory. A pull request is approved only when at least two owners of each directory - affected by the - changes have given their approval. If you are a committer and think you're ready to become an owner - of a directory, put - up a PR to the relevant OWNERs and get two owners to review it. In case of conflict between owners, - owners need to reach - consensus amongst themselves.
+ An owner of a directory in the Slang repository has the right to + approve pull requests touching the directory. + A pull request is approved only when at least one owner of each directory + affected by the changes have given their approval. Currently all members of shader-slang/dev are owners + of every directory.Language Owner: A language owner is the owner of the /docs/proposals/ All + href="https://github.com/shader-slang/spec/tree/master/proposals">proposals in the spec repository. All new Slang language and core module features (e.g. new language syntax, new functions, or new types in the Slang core module) starts with a design document - submitted to this directory. The language and core module design must be approved by two language - owners before any + submitted to this directory. The language and core module design must be approved by a language + owner before any implementation pull request for the new language feature can be approved.
@@ -119,21 +115,20 @@ intro_image_hide_on_mobile: false A bug fix starts with a GitHub issue describing the bug. Any community member can submit a pull request coming from your personal fork of Slang containing fixes for the bug. Such pull requests needs to be reviewed and - approved by two - committers who are owners of the files being changed by the pull request. Once the pull request is + approved by a + committer who is familiar with the files being changed by the pull request. Once the pull request is approved and has passed all CI tests, it can be merged to the main branch. Pull requests are expected to be reviewed by the committers within 24 hours after they are created or updated, and to - close within a week. + close within a week. + Smaller pull requests will be more likely to get quick reviews than large pull requests.Changes that add or modify syntax, language features, Slang's core module, or the compilation and reflection API must go through our process for language changes. The full process is documented here.
- Slang Feature Change Documentation - @@ -172,22 +167,3 @@ intro_image_hide_on_mobile: false - -When you are granted committer status, you will be assigned an initial set of directories that you will own based on - your record of contribution. As you continue to contribute to the project, you will naturally become the owner for any - new directories that you create. - After landing several changes to a specific directory, you can request to be an owner of the directory by submitting a - PR to modify the ./github/CODEOWNER file adding yourself to the owners list. Your PR will go through the same review - process and you will become an owner once the PR is approved and merged.
- -