From aff34a87f060ebaddbae2f9c80db404ad26b47d2 Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:06:54 -0800 Subject: [PATCH 1/6] Fix links on community page --- community/index.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/community/index.md b/community/index.md index d9e1e55f..28169c79 100644 --- a/community/index.md +++ b/community/index.md @@ -76,8 +76,8 @@ intro_image_hide_on_mobile: false

Submissions to /docs/proposals/ - considered Slang Proposed Features (SPFs), and require two Language + href="https://github.com/shader-slang/spec/tree/master/proposals">/proposals/ in the spec repository + are considered Slang Proposed Features (SPFs), and require two Language Owners (more info below) to approve the submission.

@@ -94,7 +94,7 @@ intro_image_hide_on_mobile: false consensus amongst themselves.

Language Owner: A language owner is the owner of the /docs/proposals/ All + href="https://github.com/shader-slang/spec/tree/master/proposals">proposals in the spec repository. All new Slang language and core module features (e.g. new language syntax, new functions, or new types in the Slang core module) starts with a design document From 47eadefbe6924ef2b27960a2d904654e475ce09c Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:13:57 -0800 Subject: [PATCH 2/6] Remove non-HTML newlines --- community/index.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/community/index.md b/community/index.md index 28169c79..a5b679f0 100644 --- a/community/index.md +++ b/community/index.md @@ -80,7 +80,6 @@ intro_image_hide_on_mobile: false are considered Slang Proposed Features (SPFs), and require two Language Owners (more info below) to approve the submission.

-

Owner

Every file in the Slang repository has a list of owners. An owner of a directory has the right to @@ -130,10 +129,8 @@ intro_image_hide_on_mobile: false Changes that add or modify syntax, language features, Slang's core module, or the compilation and reflection API must go through our process for language changes. The full process is documented here.

- Slang Feature Change Documentation - @@ -186,7 +183,6 @@ intro_image_hide_on_mobile: false After landing several changes to a specific directory, you can request to be an owner of the directory by submitting a PR to modify the ./github/CODEOWNER file adding yourself to the owners list. Your PR will go through the same review process and you will become an owner once the PR is approved and merged.

- From 56ec2ec154306c27077b629d09053b8d27d24360 Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:29:19 -0800 Subject: [PATCH 3/6] Correct process wrt owners --- community/index.md | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/community/index.md b/community/index.md index a5b679f0..441d914f 100644 --- a/community/index.md +++ b/community/index.md @@ -72,33 +72,30 @@ intro_image_hide_on_mobile: false reviewers who are familiar with the area of code you are touching. If you have doubts, look at the git blame for the file and the - CODEOWNER file. + CODEOWNERS file.

Submissions to /proposals/ in the spec repository - are considered Slang Proposed Features (SPFs), and require two Language - Owners (more info + are considered Slang Proposed Features (SPFs), and require a Language + Owner (more info below) to approve the submission.

Owner

- Every file in the Slang repository has a list of owners. An owner of a directory has the right to - approve pull requests - touching the directory. A pull request is approved only when at least two owners of each directory - affected by the - changes have given their approval. If you are a committer and think you're ready to become an owner - of a directory, put - up a PR to the relevant OWNERs and get two owners to review it. In case of conflict between owners, - owners need to reach - consensus amongst themselves.

+ An owner of a directory in the Slang repository has the right to + approve pull requests touching the directory. + A pull request is approved only when at least one owner of each directory + affected by the changes have given their approval. Currently all members of shader-slang/dev are owners + of every directory.

Language Owner: A language owner is the owner of the proposals in the spec repository. All new Slang language and core module features (e.g. new language syntax, new functions, or new types in the Slang core module) starts with a design document - submitted to this directory. The language and core module design must be approved by two language - owners before any + submitted to this directory. The language and core module design must be approved by a language + owner before any implementation pull request for the new language feature can be approved.

@@ -118,8 +115,8 @@ intro_image_hide_on_mobile: false A bug fix starts with a GitHub issue describing the bug. Any community member can submit a pull request coming from your personal fork of Slang containing fixes for the bug. Such pull requests needs to be reviewed and - approved by two - committers who are owners of the files being changed by the pull request. Once the pull request is + approved by a + committer who is familiar the files being changed by the pull request. Once the pull request is approved and has passed all CI tests, it can be merged to the main branch. Pull requests are expected to be reviewed by the committers within 24 hours after they are created or updated, and to From 88aefe4852ac62f6ebecbbeb482b0e2332d734e3 Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:36:01 -0800 Subject: [PATCH 4/6] Grammar fix --- community/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/community/index.md b/community/index.md index 441d914f..6ccedf30 100644 --- a/community/index.md +++ b/community/index.md @@ -116,7 +116,7 @@ intro_image_hide_on_mobile: false request coming from your personal fork of Slang containing fixes for the bug. Such pull requests needs to be reviewed and approved by a - committer who is familiar the files being changed by the pull request. Once the pull request is + committer who is familiar with the files being changed by the pull request. Once the pull request is approved and has passed all CI tests, it can be merged to the main branch. Pull requests are expected to be reviewed by the committers within 24 hours after they are created or updated, and to From fe6af5b886b152502d812af64ce5417326de150e Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:37:20 -0800 Subject: [PATCH 5/6] Remove non-applicable CODEOWNERS adding process --- community/index.md | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/community/index.md b/community/index.md index 6ccedf30..ab120f90 100644 --- a/community/index.md +++ b/community/index.md @@ -166,21 +166,3 @@ intro_image_hide_on_mobile: false - -
-
-
-
-

Request to Own More Directories -
-

-

When you are granted committer status, you will be assigned an initial set of directories that you will own based on - your record of contribution. As you continue to contribute to the project, you will naturally become the owner for any - new directories that you create. - After landing several changes to a specific directory, you can request to be an owner of the directory by submitting a - PR to modify the ./github/CODEOWNER file adding yourself to the owners list. Your PR will go through the same review - process and you will become an owner once the PR is approved and merged.

-
-
-
-
From 0df641dae89259583eba98693f88b50e60f18ac2 Mon Sep 17 00:00:00 2001 From: Aidan Foster Date: Tue, 2 Dec 2025 17:53:11 -0800 Subject: [PATCH 6/6] Add note about PR size wrt review time --- community/index.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/community/index.md b/community/index.md index ab120f90..8f39fa4d 100644 --- a/community/index.md +++ b/community/index.md @@ -120,7 +120,8 @@ intro_image_hide_on_mobile: false approved and has passed all CI tests, it can be merged to the main branch. Pull requests are expected to be reviewed by the committers within 24 hours after they are created or updated, and to - close within a week.

+ close within a week. + Smaller pull requests will be more likely to get quick reviews than large pull requests.

Process for Slang Feature Changes

Changes that add or modify syntax, language features, Slang's core module, or the compilation and