From 4827da0a2f67214792aed72f445b5a53ffcb87df Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Mon, 29 Jan 2024 23:35:43 +0100 Subject: [PATCH] src/login.c: Use localtime_r(3) instead of localtime(3) This silences a CodeQL warning. We don't care about reentrancy, but after this patch we don't need to break a long line, so that's a win. Reviewed-by: "Serge E. Hallyn" Signed-off-by: Alejandro Colomar --- src/login.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/login.c b/src/login.c index 16236de32..a862c6bdb 100644 --- a/src/login.c +++ b/src/login.c @@ -1253,10 +1253,11 @@ int main (int argc, char **argv) && pwd->pw_uid <= (uid_t) getdef_ulong ("LASTLOG_UID_MAX", 0xFFFFFFFFUL) && (ll.ll_time != 0)) { - time_t ll_time = ll.ll_time; + time_t ll_time = ll.ll_time; + struct tm tm; - STRFTIME(ptime, "%a %b %e %H:%M:%S %z %Y", - localtime(&ll_time)); + localtime_r(&ll_time, &tm); + STRFTIME(ptime, "%a %b %e %H:%M:%S %z %Y", &tm); printf (_("Last login: %s on %s"), ptime, ll.ll_line); #ifdef HAVE_LL_HOST /* __linux__ || SUN4 */