Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to controller, manager, and scheduler #2255

Merged
merged 5 commits into from Jul 5, 2022
Merged

Changes to controller, manager, and scheduler #2255

merged 5 commits into from Jul 5, 2022

Conversation

stevenengler
Copy link
Contributor

@stevenengler stevenengler commented Jul 5, 2022 •
edited

Main changes:

  • removed unnecessary complexity from the manager and scheduler
  • removed manager field from the scheduler
  • moved the status bar and plugin error count to the controller (the intended design is that the simulation may have multiple managers and a single controller, so the controller seems like a better place for these)

@stevenengler stevenengler added the Component: Main Composing the core Shadow executable label Jul 5, 2022
@stevenengler stevenengler self-assigned this Jul 5, 2022
@stevenengler stevenengler added this to In progress in Release v2.2 via automation Jul 5, 2022
@stevenengler stevenengler merged commit f56b280 into shadow:main Jul 5, 2022
Release v2.2 automation moved this from In progress to Done Jul 5, 2022
@stevenengler stevenengler deleted the manager-reorg branch July 5, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels
Component: Main Composing the core Shadow executable
Projects
No open projects
Release v2.2
Done
Milestone
Convert existing modules to Rust
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenengler @sporksmith