Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user-menu): add placeholder #1313

Merged
merged 1 commit into from Jul 7, 2020
Merged

Conversation

shadow81627
Copy link
Owner

@shadow81627 shadow81627 commented Jul 7, 2020

resolves #1314

@vercel
Copy link

vercel bot commented Jul 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/damienrobinson/pocketpasta/37q2tqee2
✅ Preview: https://pocketpasta-git-fix-user-menuplaceholder.damienrobinson.vercel.app

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          39       39           
  Lines         302      302           
  Branches       60       60           
=======================================
  Hits          228      228           
  Misses         74       74           
Impacted Files Coverage Δ
components/User/Menu.vue 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea4cdf...8f668e0. Read the comment docs.

@shadow81627 shadow81627 merged commit 1fb4e83 into master Jul 7, 2020
@shadow81627 shadow81627 deleted the fix/user-menu/placeholder branch July 7, 2020 12:55
shadow81627 pushed a commit that referenced this pull request Jul 7, 2020
  ## [0.40.1](v0.40.0...v0.40.1) (2020-07-07)

### Bug Fixes

- **auth:** only return user if we have one ([#956](#956)) ([8167f60](8167f60))
- **card:** rounded corners ([#1312](#1312)) ([e7105ca](e7105ca))
- **user-menu:** add placeholder ([#1313](#1313)) ([1fb4e83](1fb4e83))
@shadow81627
Copy link
Owner Author

🎉 This PR is included in version 0.40.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] login button loads in janky and pops in
1 participant