Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

values of cipher (or encrypt_method) should be named similar to other implementations #115

Closed
xiazuojie opened this issue Oct 29, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@xiazuojie
Copy link

commented Oct 29, 2018

For example, encrypt method known as 'chacha20-ietf-poly1305' in other implementations (and most GUI clients) is named 'AEAD_CHACHA20_POLY1305' here.
We should avoid this unnecessary confusion and use the same names.

@riobard

This comment has been minimized.

Copy link

commented Oct 30, 2018

You got it backwards. The spec is now following IANA AEAD registry. Read http://shadowsocks.org/en/spec/AEAD-Ciphers.html

@xiazuojie

This comment has been minimized.

Copy link
Author

commented Oct 31, 2018

I see. So other implementations need to be changed to use the new names.
How about the SIP002 URI scheme? According to spec, userinfo should be base64 encoded. This implementation is not doing that?
And why 'encrypt method' is called 'cipher' here?

@riobard

This comment has been minimized.

Copy link

commented Nov 1, 2018

So other implementations need to be changed to use the new names.

Yes, if they are to be compliant with the official spec.

How about the SIP002 URI scheme? According to spec, userinfo should be base64 encoded. This implementation is not doing that?

No, this implementation does not yet support SIP002. SIP002 is mostly for GUI clients, but base64 encoding makes it harder to config manually via command line.

And why 'encrypt method' is called 'cipher' here?

Because in English we say "pork" instead of "pig meat".

@riobard riobard closed this Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.