Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass LAN doesn't work. #2361

Open
axxop opened this issue Nov 22, 2019 · 18 comments
Open

Bypass LAN doesn't work. #2361

axxop opened this issue Nov 22, 2019 · 18 comments

Comments

@axxop
Copy link

@axxop axxop commented Nov 22, 2019

Describe the bug
Bypass LAN doesn't work.

To Reproduce
Select an available server, profile use "Bypass LAN and mainland China", open your router web manager page under WIFI.

Expected behavior
I can open this page.

Screenshots
None

Smartphone (please complete the following information):
Android 10 Pixel 3
Andoird 10 Emulator
Shadowsocks is latest beta version

Configuration
Put an x inside the [ ] that applies.

  • IPv4 server address
  • IPv6 server address
  • Client IPv4 availability
  • Client IPv6 availability
  • Encrypt method:
  • Route
    • All
    • Bypass LAN
    • Bypass China
    • Bypass LAN & China
    • GFW List
    • China List
    • Custom rules
  • IPv6 route
  • Apps VPN mode
    • Bypass mode
  • Remote DNS: 8.8.8.8
  • DNS over UDP
  • Plugin configuration (if applicable):
  • Auto Connect
  • TCP Fast Open
  • If you're not using VPN mode, please supply more details here:

Additional context
None

@Mygod Mygod closed this Nov 27, 2019
@axxop

This comment has been minimized.

Copy link
Author

@axxop axxop commented Nov 28, 2019

I tried the latest pixel 3 firmware (clear all data) and the latest shadowsocks beta (from play store), still not working.

@axxop

This comment has been minimized.

Copy link
Author

@axxop axxop commented Nov 28, 2019

If other information is needed, I can add it.

@iKirby

This comment has been minimized.

Copy link

@iKirby iKirby commented Nov 28, 2019

Same on my Pixel 3a, but it works on Pixel 1 with the same configuration.

@madeye

This comment has been minimized.

Copy link
Contributor

@madeye madeye commented Nov 28, 2019

Reproduced on Android 10.

It looks a bug of Android 10, which breaks the assumption that not routing traffic should fall through the underlying network interfere.

@madeye madeye added bug and removed cannot reproduce labels Nov 28, 2019
@madeye madeye reopened this Nov 28, 2019
@madeye madeye closed this in e9e5c1c Nov 28, 2019
@madeye

This comment has been minimized.

Copy link
Contributor

@madeye madeye commented Nov 28, 2019

@axxop

This comment has been minimized.

Copy link
Author

@axxop axxop commented Nov 28, 2019

Try this APK: https://drive.google.com/open?id=1jYyg8zhu2Ou9sYR76vVvjNQ7bm62aWj1

It works fine. Thanks for your work.

@iKirby

This comment has been minimized.

Copy link

@iKirby iKirby commented Nov 28, 2019

Try this APK: https://drive.google.com/open?id=1jYyg8zhu2Ou9sYR76vVvjNQ7bm62aWj1

I can also confirm that this works. Thanks!

@Mygod

This comment has been minimized.

Copy link
Contributor

@Mygod Mygod commented Dec 9, 2019

I don't understand. I cannot reproduce this on my device or emulator (after reverting e9e5c1c).

@madeye Could you share more details on this? What routing rule was changed in Android 10?

@iKirby

This comment has been minimized.

Copy link

@iKirby iKirby commented Dec 9, 2019

It seems that e9e5c1c doesn't actually fix this. I found that I still can't access FX Web Access (manage files on phone from the web) from other devices in the same LAN. (I can access router admin page though.)

This issue is probably introduced by something in November Android update.

On Pixel 1, even with the final update, security patch level is still 2019-10-06. I have Shadowsocks 4.8.5 (which doesn't contain the fix) installed on the device, and bypass LAN & China works well. I can use FX Web Access without shutting down VPN service or adding FX to bypass list.

On Pixel 3a, I updated to 2019-11-05 security patch just the second day I got the device, I didn't use FX Web Access when it was on October patch. So I'm not sure it is caused by November update, just a guess.

@axxop

This comment has been minimized.

Copy link
Author

@axxop axxop commented Dec 9, 2019

Same as @iKirby , kdeconnect-android doesn't work too.
Can't scan other devices under the same WIFI network. Works fine on older android versions (android 9)

@Mygod

This comment has been minimized.

Copy link
Contributor

@Mygod Mygod commented Dec 9, 2019

Reopen this for now for future investigation.

@madeye Can you reproduce this now?

@Mygod Mygod reopened this Dec 9, 2019
@madeye

This comment has been minimized.

Copy link
Contributor

@madeye madeye commented Dec 9, 2019

Interesting, I cannot reproduce this issue now.

@axxop

This comment has been minimized.

Copy link
Author

@axxop axxop commented Dec 9, 2019

image

Reproduced on Andoird 10 Emulator
Reproduced on OnePlus6T Android10 BuildVersion: OP6T_H2_BETA_32
Shadowsocks 4.8.5

@Mygod

This comment has been minimized.

Copy link
Contributor

@Mygod Mygod commented Dec 13, 2019

Just checked again and failed to reproduce this with both versions.

Emulator version: 29.3.0
Emulator build number: sdk_gphone_x86_64-userdebug 10 QSR1.191030.002 5978551 dev-keys QSR1.191030.002 5978551 dev-keys

@madeye I suggest we revert e9e5c1c. No matter where the packet is routed, it should always be bypassed correctly so whatever is wrong with this, it should not relate to this repo.

@madeye

This comment has been minimized.

Copy link
Contributor

@madeye madeye commented Dec 13, 2019

Sure, let's revert e9e5c1c first.

I think there's some special precondition preventing me reproducing this issue again.

I agree it looks not related to our implementation.

@Mygod

This comment has been minimized.

Copy link
Contributor

@Mygod Mygod commented Dec 18, 2019

@madeye

#2361

@Mygod It looks Google broke something in their recent security patches.

Do you have a device that has the latest security patches?

@Mygod

This comment has been minimized.

Copy link
Contributor

@Mygod Mygod commented Dec 18, 2019

Tested on Android 9 2019-12 security patches and were not able to reproduce.

@madeye

This comment has been minimized.

Copy link
Contributor

@madeye madeye commented Dec 22, 2019

I cannot reproduce either on EMUI 10 with 2019-12 security patch.

bannedbook pushed a commit to bannedbook/SpeedUp.VPN that referenced this issue Dec 25, 2019
@sanzo-mlgb sanzo-mlgb mentioned this issue Jan 5, 2020
5 of 17 tasks complete
@Mygod Mygod closed this in 2571853 Jan 11, 2020
@Mygod Mygod reopened this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.