Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow show password #1948

Closed
wants to merge 1 commit into from

Conversation

@Mygod
Copy link
Contributor

commented Sep 9, 2018

No description provided.

@Mygod Mygod added the enhancement label Sep 9, 2018
@Mygod Mygod requested a review from madeye Sep 9, 2018
@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2018

DO NOT MERGE. Succeeded by Gericop/Android-Support-Preference-V7-Fix#182.

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2018

@madeye Do you think this feature would be a good addition at all?

@madeye

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

Maybe not, as the password would not be readable at all.

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2018

Okay.

@Mygod Mygod closed this Sep 17, 2018
@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2019

@madeye Hmm, why would the password be not readable?

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

@madeye I'm considering reviving this PR. Currently the profiles can already be exported so I don't see why we need to hide the password.

@madeye

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

I think we need to hide password by default, as a best practice.

Showing password would be useful, but optional.

Mygod added a commit to Mygod/shadowsocks-android that referenced this pull request Feb 12, 2019
Also allows show password. See also shadowsocks#1948.
@Mygod Mygod deleted the Mygod:showpw branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.