Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for Android Q beta #2161

Merged
merged 22 commits into from Jun 10, 2019

Conversation

@Mygod
Copy link
Contributor

commented Mar 15, 2019

Things worth looking into:

Mygod added 7 commits Mar 15, 2019
Currently the app works fine with targeting Q so in order to test new versions on old devices, sdkVersion must be reverted.
@Prajwal-Koirala

This comment was marked as off-topic.

Copy link

commented Mar 26, 2019

Please approve this, i really need this :)

Mygod added 2 commits Mar 26, 2019
@Mygod Mygod force-pushed the q-beta branch from f4262d5 to f141dfb Mar 26, 2019
@Mygod Mygod changed the title Update API for Android Q beta Enhancements for Android Q beta Mar 26, 2019
Mygod referenced this pull request May 28, 2019
Mygod added 2 commits May 30, 2019
They say that beta is ready for production.
@Mygod Mygod force-pushed the q-beta branch from 48a00c0 to 7ab3eb3 Jun 6, 2019
@Mygod Mygod requested a review from madeye Jun 6, 2019
@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Updated to API 29. Ready to merge.

@Mygod Mygod added the enhancement label Jun 6, 2019
@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@madeye Any comments?

@madeye

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

I'm traveling now. I'll take a look next week.

@madeye
madeye approved these changes Jun 10, 2019
Copy link
Contributor

left a comment

Tested on a simulator. LGTM.

@Mygod Mygod merged commit 685f840 into master Jun 10, 2019
2 of 3 checks passed
2 of 3 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
License Compliance All checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
@Mygod Mygod deleted the q-beta branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.