Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2209 #2211

Merged
merged 6 commits into from May 21, 2019

Conversation

@Mygod
Copy link
Contributor

commented May 18, 2019

This is a basic fix for #2209.

This has an unwanted side effect: MainActivity will no longer respond to android.intent.action.VIEW (for ss URIs) if it is not in the top of the task. This intent should probably be handled in a separate Activity or sort. UPDATE: Fixed.

Relevant links for why such fix:

@Mygod Mygod added the enhancement label May 18, 2019
@Mygod Mygod requested a review from madeye May 18, 2019
@madeye

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

Looks a valid fix.

Is it possible we still use singleTask mode but restore fragment states when the activity is started again by the launcher?

@Mygod

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

Do you mean restore task back stack? I don't know but I imagine that would be more work.

@madeye

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

Yeah, I think so. Let's go this solution.

@madeye
madeye approved these changes May 19, 2019
Copy link
Contributor

left a comment

LGTM

Mygod added 3 commits May 20, 2019
Also deprecates discovering from NFC/Android Beam due to deprecation in Android Q.
A follow-up commit will remove this feature completely.
@Mygod Mygod marked this pull request as ready for review May 21, 2019
@Mygod Mygod merged commit 0bd0207 into master May 21, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
License Compliance All checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
@Mygod Mygod deleted the fix-2209 branch May 21, 2019
@Mygod Mygod referenced this pull request May 21, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.