Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2308

Merged
merged 3 commits into from Sep 19, 2019

Conversation

@Mygod
Copy link
Contributor

commented Sep 17, 2019

Fixes #2306.

Warning: While errors are unlikely, this PR is untested because I do not have time.

@VMadalin For the rest of your changes, there are good reasons (to me) to ignore the warnings and not suppress them at the same time.

Fixes #2306.
@Mygod Mygod added the enhancement label Sep 17, 2019
@Mygod Mygod requested a review from madeye Sep 17, 2019
@VMadalin

This comment has been minimized.

Copy link

commented Sep 17, 2019

Thank you for make the patch of some change from my PR and added new one. I understand your point of view to ignore the rest of warnings for the moment, and don't tacking them into count. But remember some of them are more or less important like the following, and they should not be forgotten.

Internationalization:Bidirectional Text
--
2 | warning RtlHardcoded: Using left/right instead of start/end attributes
1 | warning RtlEnabled: Using RTL attributes without enabling RTL support

This break the layout for arabic languages.

@madeye
madeye approved these changes Sep 17, 2019
Copy link
Contributor

left a comment

LGTM

@Mygod Mygod merged commit 11c09ef into shadowsocks:master Sep 19, 2019
0 of 2 checks passed
0 of 2 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
ci/circleci CircleCI is running your tests
Details
@Mygod Mygod deleted the Mygod:update branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.