Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission for receiver #2334

Merged
merged 4 commits into from Dec 9, 2019
Merged

Add permission for receiver #2334

merged 4 commits into from Dec 9, 2019

Conversation

@shadowsocksRb
Copy link
Contributor

shadowsocksRb commented Oct 28, 2019

修复可被任意应用控制VPN服务问题

@madeye madeye requested a review from Mygod Oct 28, 2019
Copy link
Contributor

Mygod left a comment

If this code is tested then I have no further comments. I will make some changes to this after #2335 is merged.

Mygod added 3 commits Dec 9, 2019
This provides barely any protection and might break compatibility with older version of Tasker.
@Mygod Mygod merged commit 960d18d into shadowsocks:master Dec 9, 2019
1 of 2 checks passed
1 of 2 checks passed
ci/circleci CircleCI is running your tests
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@Mygod

This comment has been minimized.

Copy link
Contributor

Mygod commented Dec 9, 2019

Also merged. Thanks again!

@shadowsocksRb shadowsocksRb deleted the shadowsocksRb:ss-patch-1 branch Dec 10, 2019
@shadowsocksRb

This comment has been minimized.

Copy link
Contributor Author

shadowsocksRb commented Dec 10, 2019

在合并中丢失了将ACTION_PACKAGE_REMOVED 替换为ACTION_PACKAGE_FULLY_REMOVED 的修改。这种情况下再去掉EXTRA_REPLACING的判断将包括升级的应用。这是预期的吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.