Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to zhanghai's AndroidFastScroll #2382

Merged
merged 3 commits into from Dec 11, 2019
Merged

Conversation

@Mygod
Copy link
Contributor

Mygod commented Dec 10, 2019

This library is from Google and has PopupTextProvider.

@Mygod Mygod added the enhancement label Dec 10, 2019
@Mygod Mygod requested a review from madeye Dec 10, 2019
@Mygod Mygod changed the title Migrate to @zhanghai's AndroidFastScroll Migrate to zhanghai's AndroidFastScroll Dec 10, 2019
Mygod added 2 commits Dec 10, 2019
@Mygod

This comment has been minimized.

Copy link
Contributor Author

Mygod commented Dec 11, 2019

@madeye Any comments? This PR is tested and works alright on my side.

@madeye
madeye approved these changes Dec 11, 2019
Copy link
Contributor

madeye left a comment

LGTM

@Mygod Mygod merged commit b61e3d3 into shadowsocks:master Dec 11, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci Your tests passed on CircleCI!
Details
@Mygod Mygod deleted the Mygod:zhanghai-fastscroll branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.