-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Refactoring for configurable DNS upstreams & some other refinements #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we also have this? madeye@055b4f6 |
|
With these changes, Android client should behave reasonably with any reasonable ACL file. |
|
49966d9 seems breaking everything... |
|
@madeye Are you seeing |
|
Try 13bcc5d. |
|
To reproduce the issue, please use bypass China route. |
|
d1a3ac6 should fix the issue. |
madeye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@zonyitoo In that case feel free to comment on where the code doesn't make sense and I can try to explain... Also maybe just merge this instead of rebasing it? There are too many commits now and I don't want to squash everything. |
|
I saw in ACL, resolving |
|
Ah, my fault. I found that just now. |
I am not going to pretend I know what I am doing with these code.