Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Config Form #2410

Merged
merged 4 commits into from Jun 25, 2019

Conversation

@Stzx
Copy link
Contributor

commented Jun 15, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

Fix #1907

Still need further testing.

馃榾

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Stzx added 4 commits Jun 15, 2019
Add new hints and fixed some old interaction bugs
Added Config Form hint text
@Stzx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

Consider upgrading the version of the appveyor mirror ?

The current .Net Framework version of the project is 4.6.2, and compiling with the VS 2015 image version is obviously not suitable for the current .Net Framework 4.6.2 version.

If I don't upgrade, I roll back and modify the code.

@celeron533

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Sorry, I'm too busy these days. I'll check it soon.

@@ -88,23 +89,31 @@ private void ConfigValueChanged(object sender, EventArgs e)
ApplyButton.Enabled = true;
}

private bool ValidateAndSaveSelectedServerDetails()
[MethodImpl(MethodImplOptions.AggressiveInlining)]

This comment has been minimized.

Copy link
@celeron533

celeron533 Jun 25, 2019

Collaborator

Force compiler to inline for performance boost?

This comment has been minimized.

Copy link
@Stzx

Stzx Jun 25, 2019

Author Contributor

杩欓噷鐩墠鐪嬫潵锛屼笉浼氬緱鍒版ц兘涓婄殑鎻愬崌锛屽彲浠ュ湪鍚堝苟鏃跺皢鍏跺墧闄ゃ

This comment has been minimized.

Copy link
@celeron533

celeron533 Jun 25, 2019

Collaborator

Never mind. Could leave it.

@celeron533 celeron533 merged commit d6089b4 into shadowsocks:master Jun 25, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.