Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2458 Unexpected server delete behavior #2459

Merged
merged 2 commits into from Jul 14, 2019

Conversation

@Stzx
Copy link
Contributor

commented Jul 14, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

修复删除时事件触发导致,错误的删除。

修改服务器列表位置调整逻辑,与 4.16 版本保持一致。

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@imba-tjd

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

嗯,这样是可以删掉正确的条目,但是还是会跳到最后一项。你试一下4.1.6的效果

@imba-tjd

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

忽然发现,复制也应该是差不多的逻辑。4.1.6就在下一个地方生成重复的条目,现在4.1.7变成了在最后生成。

@Stzx

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

删除可以考虑保留当前位置,复制的话由于会定位到复制的位置,倒是没什么关系。

你觉得呢? @imba-tjd

@imba-tjd

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

我个人意见是和4.1.6的行为保持一致……

@celeron533 celeron533 changed the title Fix #2458 Fix #2458 Unexpected delete server behavior Jul 14, 2019
@celeron533 celeron533 merged commit b708927 into shadowsocks:master Jul 14, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@celeron533 celeron533 changed the title Fix #2458 Unexpected delete server behavior Fix #2458 Unexpected server delete behavior Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.