Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch configuration enable button #2460

Merged
merged 4 commits into from Jul 14, 2019

Conversation

@Stzx
Copy link
Contributor

commented Jul 14, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

完善用户操作习惯,在切换配置时启用应用按钮,而不是配置内容修改时。

#2457

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@celeron533 celeron533 merged commit 12ffdcc into shadowsocks:master Jul 14, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
celeron533 added a commit to celeron533/shadowsocks-windows that referenced this pull request Jul 14, 2019
@yanggis

This comment has been minimized.

Copy link

commented Sep 30, 2019

感觉4.1.7.1使用开启按钮配置完全没必要,以前版本只要点右键调出背景菜单,然后选择启用还是禁用即可,只需要点两次,现在要点三次才能完成,非常麻烦,建议改回去。

@Stzx

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

开启按钮配置

具体是指?我不太清楚。

@yanggis

This comment has been minimized.

Copy link

commented Oct 1, 2019

在飞机上点右键,打开菜单,选择服务器,禁用,这几步操作,以前版本只要点右键调出背景菜单,然后选择启用还是禁用即可,只需要点两次,现在要点三次才能完成,非常麻烦,建议改回去。

@yanggis

This comment has been minimized.

Copy link

commented Oct 1, 2019

从4.1.5开始改的。

@chenshaoju

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

他说的应该是以前的那个”启用系统代理“的选项。

以前启用系统代理后再决定PAC或者全局。

但是很多人搞不清,认为只要选择了PAC或者全局就行了。

所以后来改了,整合到了系统代理菜单中,变成了禁用、PAC、全局。

这个很难权衡。

PS:如果你觉得麻烦,我建议你设置一个快捷键,这样鼠标都不用使用:
image

@yanggis

This comment has been minimized.

Copy link

commented Oct 1, 2019

这种改变想法是好的,但是结果却不理想,原本两次点击就完成,现在都变成三次操作完成。。。

@Stzx

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@yanggis 你可以考虑开一个 Issuse 讨论,这个PR并没有做相关修改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.