Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default method to chacha20-ietf-poly1305 #2699

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@studentmain
Copy link
Collaborator

studentmain commented Nov 25, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

#2668 , update default method to reflect change of protocol and server.

@@ -83,7 +83,9 @@
<HintPath>..\packages\Newtonsoft.Json.12.0.2\lib\net45\Newtonsoft.Json.dll</HintPath>
</Reference>
<Reference Include="PresentationCore" />
<Reference Include="System" />
<Reference Include="System">
<HintPath>..\..\..\..\..\..\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\System.dll</HintPath>

This comment has been minimized.

Copy link
@celeron533

celeron533 Nov 26, 2019

Collaborator

We should ignore this kind of change

@studentmain studentmain force-pushed the studentmain:default-method branch from 4235747 to f01ccd8 Nov 26, 2019
@ningsibuqu

This comment has been minimized.

Copy link

ningsibuqu commented Nov 26, 2019

感觉默认aes-256-gcm会好一点

@studentmain

This comment has been minimized.

Copy link
Collaborator Author

studentmain commented Nov 26, 2019

感觉默认aes-256-gcm会好一点

三个常见服务端全部默认chacha20-ietf-poly1305

@celeron533 celeron533 merged commit 8039822 into shadowsocks:master Nov 28, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@studentmain studentmain deleted the studentmain:default-method branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.