Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n #2712

Merged
merged 4 commits into from Dec 21, 2019
Merged

Improve i18n #2712

merged 4 commits into from Dec 21, 2019

Conversation

@studentmain
Copy link
Collaborator

studentmain commented Dec 3, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

  1. TranslateForm function
  2. CSV file for easy management
  3. Load translation from disk
@studentmain studentmain requested a review from celeron533 Dec 18, 2019
@celeron533

This comment has been minimized.

Copy link
Collaborator

celeron533 commented Dec 18, 2019

I'm not sure if there comes a new language, how to do the maintenance?

@studentmain

This comment has been minimized.

Copy link
Collaborator Author

studentmain commented Dec 18, 2019

how to do the maintenance?

Add a new column with language identifier. We can open CSV in Excel or other editor

celeron533 added a commit to celeron533/shadowsocks-windows that referenced this pull request Dec 21, 2019
celeron533 added a commit to celeron533/shadowsocks-windows that referenced this pull request Dec 21, 2019
@celeron533 celeron533 merged commit 18f4486 into shadowsocks:master Dec 21, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@studentmain studentmain deleted the studentmain:i18n branch Dec 21, 2019
@chenshaoju

This comment has been minimized.

Copy link
Collaborator

chenshaoju commented Dec 22, 2019

At 4.1.9.0, There is a file name i18n.csv automatic generation at the Shadowsocks.exe folder.

I suggest moving to the ss_win_temp folder if necessary.

@studentmain

This comment has been minimized.

Copy link
Collaborator Author

studentmain commented Dec 22, 2019

Or generate it on demand, add a menu entry, click it to generate i18n.csv, if no external i18n.csv, use builtin one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.