Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify concurrency value of multiplexing #10

Merged
merged 2 commits into from Jan 17, 2019
Merged

Option to specify concurrency value of multiplexing #10

merged 2 commits into from Jan 17, 2019

Conversation

linusyang
Copy link
Contributor

Free plan of cloudflare may have limits on websocket connections. It would be better to give users an option to specify concurrency larger than 1.

The explanation of concurrency option can be found at
https://github.com/v2ray/manual/blob/master/en/configuration/mux.md

Copy link
Collaborator

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If my site uses more concurrent WebSockets connections than Cloudflare expects, what will happen?

Immediately, nothing. Within reason, Cloudflare will allow occasional spikes in usage beyond our guidelines, and we will not apply unnecessary limits.

Repeated spikes or high continued usage will prompt a dialogue: we'll reach out to learn more about your application. Barring abuse or attack, we will not impose limits errors for any application without contacting the customer.

Customers whose usage claims a disproportionate percentage of resources for their current plan level may be asked to upgrade to the plan level that matches their needs.

@linusyang
Copy link
Contributor Author

@Mygod Yes, I checked this page before. Cloudflare is very generous. 🤣 Multiplexing also may help (a bit) hiding some characteristics.

Some discussion on another plugin:
https://github.com/cbeuw/Cloak
cbeuw/GoQuiet#33

@VictoriaRaymond
Copy link
Contributor

Maybe default to a larger value, say 16?

@madeye madeye merged commit 4cef515 into shadowsocks:master Jan 17, 2019
@linusyang
Copy link
Contributor Author

I think the design of SS prefers no multiplexing at all:
shadowsocks/shadowsocks-libev#1444

So default value 1 may be more intuitive for most SS users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants