Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: always use detailed VP9 codec strings with profile info #406

Closed
joeyparrish opened this issue Jun 1, 2018 · 4 comments
Closed
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

For background, see w3c/media-capabilities#85. To summarize that, the MediaCapabilities API will not accept codecs="vp9", even for video/webm. It will require the use of a full vp9 codec string with profile info, such as codecs="vp09.00.10.08".

I would like Shaka Packager to output such a string for VP9, regardless of manifest or container formats.

I checked VP9 support via MediaSource.isTypeSupported on Firefox, Chrome, Safari, IE, and Edge on various platforms, with both MP4 and WebM. I found that with up-to-date browsers, any platform that supports codecs="vp9" also supports codecs="vp09.00.10.08".

The browsers which currently support VP9 are Chrome, Firefox, and Edge. Since all of those are "evergreen" browsers which auto-update, I don't think we need to be concerned about compatibility with older versions of those browsers that might not understand the new codec strings.

If an older version of Chrome or Firefox were still in use by a small segment of users, service providers that target multiple browsers would almost certainly have MP4/H.264 content available as a fallback, and those older browsers could still use that.

Therefore I expect this is a low-risk change.

@vaage vaage added type: enhancement New feature or request and removed needs triage labels Jun 1, 2018
@vaage vaage added this to the Backlog milestone Jun 1, 2018
@vaage
Copy link
Contributor

vaage commented Jun 1, 2018

@joeyparrish Thank you for bringing this to our attention.

I have labeled this work as an "enhancement" and have put it in our backlog so that it will be taken into consideration during our next planning session.

@kqyang kqyang modified the milestones: Backlog, v2.2 Jun 5, 2018
@suzande
Copy link

suzande commented Jun 12, 2018

Content was tested replacing the Media Identifier of "vp9" to codecs="vp09.00.10.08" in the --mpd_output *.mpd file. Verified playback using Shaka Player v2.4.0-uncompiled, ExoPlayer V1 and ExoPlayer V2.

@kqyang
Copy link
Collaborator

kqyang commented Jun 12, 2018

@suzande Thanks for the verification!

@kqyang
Copy link
Collaborator

kqyang commented Jun 29, 2018

Cherry-picked to v2.1.1.

kqyang added a commit that referenced this issue Jun 29, 2018
Configurable under flag --use_legacy_vp9_codec_string, which defaults
to false as all major browsers and platforms support new style vp09
codec string already.

Closes #406.

Change-Id: I22e917777f9d66db815ff9d55eb47b6d55806269
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 11, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants