From df056925ed414e06d6a6512eeeda62e25887fe51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Velad=20Galv=C3=A1n?= Date: Tue, 9 Jan 2024 09:41:54 +0100 Subject: [PATCH] fix(UI): Fix the scrolling when scrolling from the laterals when seekOnTaps is enabled (#6050) Fixes https://github.com/shaka-project/shaka-player/issues/6027 --- ui/hidden_seek_button.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/hidden_seek_button.js b/ui/hidden_seek_button.js index 5ea5138936..4c03c7839d 100644 --- a/ui/hidden_seek_button.js +++ b/ui/hidden_seek_button.js @@ -44,7 +44,11 @@ shaka.ui.HiddenSeekButton = class extends shaka.ui.Element { this.seekContainer = shaka.util.Dom.createHTMLElement('div'); this.parent.appendChild(this.seekContainer); - this.eventManager.listen(this.seekContainer, 'touchstart', (event) => { + this.eventManager.listen(this.seekContainer, 'touchend', (event) => { + // Do nothing if the controls are not visible + if (!this.controls.isOpaque()) { + return; + } // In case any settings menu are open this assigns the first touch // to close the menu. if (this.controls.anySettingsMenusAreOpen()) {