diff --git a/build/build.py b/build/build.py index 7c1af9951a..bbc1dfb1a3 100755 --- a/build/build.py +++ b/build/build.py @@ -60,13 +60,6 @@ # about the old one. '--jscomp_off=deprecatedAnnotations', - # 'analyzerChecks' complains about countless instances of implicitly - # nullable types, plus a few other issues. Even the closure library doesn't - # pass these checks, and the implicit nullability check in particular is - # over-zealous and unhelpful. So we disable the whole category of - # 'analyzerChecks'. - '--jscomp_off=analyzerChecks', - '--extra_annotation_name=listens', '--extra_annotation_name=exportDoc', @@ -238,6 +231,7 @@ def build_raw(self, extra_opts): 'third_party', 'closure', 'compiler.jar') jar = shakaBuildHelpers.cygwin_safe_path(jar) files = [shakaBuildHelpers.cygwin_safe_path(f) for f in self.include] + files.sort() try: cmd_line = ['java', '-jar', jar] + closure_opts + extra_opts + files diff --git a/build/check.py b/build/check.py index f7ea652089..71b16d3488 100755 --- a/build/check.py +++ b/build/check.py @@ -131,7 +131,8 @@ def get(*args): # Ignore missing goog.require since we assume the whole library is # already included. - opts = ['--jscomp_off=missingRequire', '--checks-only', '-O', 'SIMPLE'] + opts = ['--jscomp_off=missingRequire', '--jscomp_off=strictMissingRequire', + '--checks-only', '-O', 'SIMPLE'] return test_build.build_raw(opts) diff --git a/externs/htmltrackelement.js b/externs/htmltrackelement.js deleted file mode 100644 index c018450019..0000000000 --- a/externs/htmltrackelement.js +++ /dev/null @@ -1,57 +0,0 @@ -/** - * @license - * Copyright 2016 Google Inc. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -/** - * @fileoverview Externs for HTMLTrackElement. - * @externs - */ - - - -/** - * @constructor - * @extends {HTMLElement} - */ -function HTMLTrackElement() {} - - -/** @type {string} */ -HTMLTrackElement.prototype.kind; - - -/** @type {string} */ -HTMLTrackElement.prototype.src; - - -/** @type {string} */ -HTMLTrackElement.prototype.srclang; - - -/** @type {string} */ -HTMLTrackElement.prototype.label; - - -/** @type {boolean} */ -HTMLTrackElement.prototype.default; - - -/** @const {TextTrack} */ -HTMLTrackElement.prototype.track; - - -/** @const {string} */ -TextTrack.prototype.id; diff --git a/test/media/drm_engine_integration.js b/test/media/drm_engine_integration.js index f5ac539daf..d5ddbb18b4 100644 --- a/test/media/drm_engine_integration.js +++ b/test/media/drm_engine_integration.js @@ -52,8 +52,8 @@ describe('DrmEngine', function() { jasmine.DEFAULT_TIMEOUT_INTERVAL = 12000; // ms video = /** @type {HTMLVideoElement} */ (document.createElement('video')); - video.width = '600'; - video.height = '400'; + video.width = 600; + video.height = 400; video.muted = true; document.body.appendChild(video); diff --git a/test/media/media_source_engine_integration.js b/test/media/media_source_engine_integration.js index 033bacfa1c..c973b56fbd 100644 --- a/test/media/media_source_engine_integration.js +++ b/test/media/media_source_engine_integration.js @@ -57,8 +57,8 @@ describe('MediaSourceEngine', function() { beforeAll(function(done) { video = /** @type {HTMLVideoElement} */ (document.createElement('video')); - video.width = '600'; - video.height = '400'; + video.width = 600; + video.height = 400; document.body.appendChild(video); originalTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL; diff --git a/test/media/streaming_engine_integration.js b/test/media/streaming_engine_integration.js index 3644a949f7..6ca11061ea 100644 --- a/test/media/streaming_engine_integration.js +++ b/test/media/streaming_engine_integration.js @@ -72,8 +72,8 @@ describe('StreamingEngine', function() { jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000; // ms video = /** @type {HTMLVideoElement} */ (document.createElement('video')); - video.width = '600'; - video.height = '400'; + video.width = 600; + video.height = 400; video.muted = true; document.body.appendChild(video); }); diff --git a/test/offline/offline_integration.js b/test/offline/offline_integration.js index b44c57e46f..973ef761e7 100644 --- a/test/offline/offline_integration.js +++ b/test/offline/offline_integration.js @@ -25,8 +25,8 @@ describe('Offline', function() { beforeAll(/** @suppress {accessControls} */ function(done) { video = /** @type {!HTMLVideoElement} */ (document.createElement('video')); - video.width = '600'; - video.height = '400'; + video.width = 600; + video.height = 400; video.muted = true; document.body.appendChild(video); diff --git a/test/player_integration.js b/test/player_integration.js index b6b81b4d41..b8bb65ebcc 100644 --- a/test/player_integration.js +++ b/test/player_integration.js @@ -33,8 +33,8 @@ describe('Player', function() { beforeAll(function(done) { video = /** @type {!HTMLVideoElement} */ (document.createElement('video')); - video.width = '600'; - video.height = '400'; + video.width = 600; + video.height = 400; video.muted = true; document.body.appendChild(video); diff --git a/third_party/SUMMARY.txt b/third_party/SUMMARY.txt index eb737c7621..0988aac4df 100644 --- a/third_party/SUMMARY.txt +++ b/third_party/SUMMARY.txt @@ -1,6 +1,5 @@ closure/compiler.jar - The closure compiler, v20160208 + patches, by Google. - Cherry-picked 3734b26b to remove bogus arguments checks. + The closure compiler, v20160713, by Google. Apache v2.0 license. https://github.com/google/closure-compiler diff --git a/third_party/closure/compiler.jar b/third_party/closure/compiler.jar index b7545af814..6dff2d0444 100644 Binary files a/third_party/closure/compiler.jar and b/third_party/closure/compiler.jar differ