-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minBufferTime config should not be overriden by dash manifest #1547
Comments
Hi, thanks for reaching out. Having config be the source of truth might mean we're no longer compliant with the dash spec, but let me see if our TL is open to a discussion on this @joeyparrish |
That seems reasonable. I'll put this on the backlog, but we would be happy to accept a PR for this if you have time to work on it. Thanks! |
yes sure i’ll prepare a PR in the following weeks |
this seems less easy than i first thought because of the following flow: so when the parser get the dash manifest i can think of some hack around it, but i don't like that i'll need more time to come with a proper solution if any, so i'll let you know ideas welcome |
@fadomire I'll want @joeyparrish to chime in on this suggestion, but what we could do is replace From the manifest parser they would then have a callback usable as:
and
The library could provide a default like:
Then apps could replace it further with whatever logic they need/want. |
@vaage thanks for the suggestion, it seems a good path i still made a pull request with minor changes, but i feel it does not fit well with the current code flow : tho i will use this fork for demo purpose and see later how shaka team wants to implement it |
After some more discussion internally, I think we should add the config field |
i updated the PR #1581 to implement manifest.dash.ignoreMinBufferTime logic let me know if ok for you or if it needs some tweak thanks ! |
Released in v2.5.0-beta2. |
Hello, i understand that currently the code behave as follow :
A DASH manifest's minBufferTime, if greater, overrides rebufferingGoal.
The problem i see in that behavior is that client knows better about network conditions and may want to adapt the rebufferingGoal value based on that. Currently it is not possible.
Why not make the following rule :
config takes precedence over dash manifest that takes precedence over default value
The text was updated successfully, but these errors were encountered: