fix: Issue with compiler minifying webOS device properties #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 0.00% |
joeyparrish
approved these changes
May 8, 2024
avelad
added a commit
that referenced
this pull request
May 8, 2024
Fixes #6533 The original author is: @stuartflanagan The original PR is: #6554
| @@ -684,8 +684,8 @@ shaka.util.Platform = class { | |||
| /** @type {{screenWidth: number, screenHeight: number}} */( | |||
| JSON.parse(window.PalmSystem.deviceInfo)); | |||
| // WebOS has always been able to do 1080p. Assume a 1080p limit. | |||
| maxResolution.width = Math.max(1920, deviceInfo.screenWidth); | |||
| maxResolution.height = Math.max(1080, deviceInfo.screenHeight); | |||
| maxResolution.width = Math.max(1920, deviceInfo['screenWidth']); | |||
There was a problem hiding this comment.
😮 Can someone explain why?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6533
The original author is: @stuartflanagan
The original PR is: #6554