Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: silently try com.microsoft.playready.recommendation before com.microsoft.playready #2750
feat: silently try com.microsoft.playready.recommendation before com.microsoft.playready #2750
Changes from 33 commits
9354f04
678e005
7925fb2
ed41a9d
d20cee1
021306b
b011cfc
e7e045d
a5733e1
d524b02
c29c6b1
3adf032
90eae8a
dc4ddaf
740abc9
785072b
4d164f5
f052a7e
89db3a0
1a9cb6f
c0c88dd
dfb1de5
0c38322
1ad81c8
fbff53c
fb0897c
7fe9fc8
96c85cc
5940905
a1f3503
7d4b1ed
ab6e143
9aa90a1
9d8fcda
0209264
0cf8d7a
e229bde
a1a832a
70a5652
94bd5e2
fe65b22
64efd53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a single string, since you only ever use sessionTypes[0] in DrmEngine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep the same field names as the MediaKeySystemAccess configuration, to keep consistency between the DRMEngine configuration, the given configuration to navigator APIs and the one we receive from them.
Is that okay for you ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire array is passed to requestMediaKeySystemAccess, but only using sessionTypes[0] still seems like an issue to me. EME says that all session types in the array are considered required in the query. But what is the purpose of the second and subsequent members of the array if we ignore them?
Having an array implies that we will use all the values somehow. I don't want to field bug reports later that say things like "I asked for temporary & persistent, but only got temporary sessions! I wanted you to read my mind and do temporary for these keys and persistent for those keys." And if we later decide that this was a mistake, and we should represent the config as a single value (since that's all we can use), we would have to go to Shaka v4 before we could drop the more confusing version of the config.
The API shape of Shaka Player (including the config) should reflect what we will actually use, rather than exactly how we will pass the values to an underlying browser API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your point makes total sense, I'll change it