fix: correctly detect Edge Chromium as Edge #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Sep 17, 2020
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this pull request
Sep 25, 2020
Without this, shaka-project#2801 is broken on the latest versions of Edge
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this pull request
Sep 25, 2020
Without this, shaka-project#2801 is broken on the latest versions of Edge
joeyparrish
pushed a commit
that referenced
this pull request
Sep 29, 2020
Without this, #2801 is broken on the latest versions of Edge
|
@joeyparrish I would suggest to have a line in the changelog on the impacted Releases to warn potential users about that issue |
|
We haven't made a new release yet, but I'm working on it. The fix will be in v3.0.5 and v2.5.17 and will definitely be mentioned in the changelog and release announcement. |
joeyparrish
pushed a commit
that referenced
this pull request
Oct 1, 2020
Without this, #2801 is broken on the latest versions of Edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Edge Chromium UA example:
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.74 Safari/537.36 Edg/79.0.309.43Since #2801, trying to play PlayReady content with Shaka on Edge Chromium would result in a MANIFEST_RESTRICTIONS_CANNOT_BE_MET error since it wasn't selected to do the endianness black magic.
Edge Chromium should be detected as Edge to correctly correct the key endianness.
This affects the
v3.0.4andv2.5.16releases.