Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make drm sessionType configurable in advanced DRM config #3301



Copy link

@valotvince valotvince commented Apr 1, 2021


Following #2750 , I've stripped everything talking about playready recommendation and kept only the sessionType override

Added a new field in the DRM AdvancedConfig sessionType allowing to force a specific MediaKey session to be created with that sessionType. Particularly useful when we issue purchase licenses, and the whole decryption chain checks for the configuration to be nice & pretty (unlike

Screenshots (optional)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update


  • I have signed the Google CLA
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/ and the build passes
  • I have run ./build/ and all tests pass

@valotvince valotvince marked this pull request as ready for review April 1, 2021 13:25
Copy link

All tests passed!

@joeyparrish joeyparrish merged commit 4574a5d into shaka-project:master Apr 1, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants