feat: add serverCertificateUri in DRM advanced config#3358
Merged
joeyparrish merged 7 commits intoshaka-project:masterfrom May 3, 2021
Merged
feat: add serverCertificateUri in DRM advanced config#3358joeyparrish merged 7 commits intoshaka-project:masterfrom
joeyparrish merged 7 commits intoshaka-project:masterfrom
Conversation
TheModMaker
suggested changes
Apr 27, 2021
| .addLicenseServer('com.widevine.alpha', 'https://cwip-shaka-proxy.appspot.com/no_auth'), | ||
| .addLicenseServer('com.widevine.alpha', 'https://cwip-shaka-proxy.appspot.com/no_auth') | ||
| .setExtraConfig({drm: {advanced: {'com.widevine.alpha': {serverCertificateUri: | ||
| 'https://storage.googleapis.com/wvmedia/cert/cert_license_widevine_com_uat.bin'}}}}), |
Contributor
There was a problem hiding this comment.
This isn't really needed as the CDM will request it for us anyway. I'd suggest dropping the demo changes to make things simpler.
Contributor
Author
There was a problem hiding this comment.
Yep, it was just to have a working example with the serverCertificateUri. I could drop it or comment to explain this shouldn't be needed, but it is here to demonstrate the feature, WYT ?
7360ea4 to
74c86a9
Compare
Contributor
Author
|
@TheModMaker 👋 I've pushed some edits base on your review, thanks ! |
TheModMaker
approved these changes
Apr 30, 2021
Collaborator
|
Test Failure: |
Collaborator
|
All tests passed! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1906
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests passWorks when running alone but doesn't when running with all the other tests (same thing on master)