Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ENV specific values to have a default #356

Merged
merged 1 commit into from Aug 15, 2018
Merged

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Aug 13, 2018

If the NODE_ENV specific value for a setting is not found, then a
non-env specific value is used.


This change is Reviewable

If the NODE_ENV specific value for a setting is not found, then a
non-env specific value is used.
Copy link
Member Author

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alexfedoseev)


src/utils/getEnvProp.js, line 9 at r1 (raw file):

 */
export default function(prop, config) {
  if (prop in config) {

@alexfedoseev I moved this to be used after the node specific value is not found. This is the only change worth reviewing.

Copy link
Member Author

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfedoseev please do a post-review if I already merged.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alexfedoseev)

@justin808 justin808 merged commit f01042b into master Aug 15, 2018
@justin808 justin808 deleted the get-env-value-first branch August 15, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant