New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider integration with react-stdio for server rendering #183

Closed
justin808 opened this Issue Jan 4, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@justin808
Copy link
Member

justin808 commented Jan 4, 2016

@mjackson has created react-stdio. We should look into integrating this with react_on_rails.

@alexfedoseev: this looks promising
@cowboyd: Any thoughts on this compared to what we currently use: https://github.com/cowboyd/therubyracer

@justin808 justin808 changed the title Consider integration Consider integration with react-stdio for server rendering Jan 4, 2016

@mjackson

This comment has been minimized.

Copy link

mjackson commented Jan 4, 2016

Just for clarification, it's react-stdio, not react-studio :)

On Mon, Jan 4, 2016 at 1:31 PM Justin Gordon notifications@github.com
wrote:

@mjackson https://github.com/mjackson has created react-studio. We
should look into integrating this with react_on_rails.

@alexfedoseev https://github.com/alexfedoseev: this looks promising
@cowboyd https://github.com/cowboyd: Any thoughts on this compared to
what we currently use: https://github.com/cowboyd/therubyracer


Reply to this email directly or view it on GitHub
#183.

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Jan 4, 2016

@mjackson Thanks. Studio sounds kind of cool 😃.
Any thoughts on a Rails integration?

@mjackson

This comment has been minimized.

Copy link

mjackson commented Jan 4, 2016

Probably the first step would be to create a Ruby wrapper for react-stdio that knows how to feed its stdin and parse its stdout. After that, integration with Rails should be fairly straightforward.

@justin808 justin808 modified the milestones: 2.3, 3.0 Jan 21, 2016

@aaronvb

This comment has been minimized.

Copy link
Member

aaronvb commented Feb 2, 2016

I looked into implementing this into react_on_rails(and in react-rails). With our current server rendering method it's not going to work 'out of the box'. react-stdio takes a path to a component whereas we pass a string of JS code(with polyfills) to ExecJS(therubyracer).

I ended up writing a little react-stdio wrapper for Rails that could be helpful in pursuing this option: https://github.com/aaronvb/rails_react_stdio.

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Feb 2, 2016

@aaronvb If you get this working, you will be a

HERO

@justin808 justin808 modified the milestones: 4.0, 3.0 Feb 9, 2016

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Feb 9, 2016

@aaronvb any word on this one?

@aaronvb

This comment has been minimized.

Copy link
Member

aaronvb commented Feb 9, 2016

@justin808 I haven't put much work into this. I'm open to pairing up or starting a branch for collaboration on this.

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Mar 31, 2016

@aaronvb Any progress on this one? We really should try this one!

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented May 6, 2016

Closed by #380

@justin808 justin808 closed this May 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment