Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Arrays in Rails i18n yml files #1129

Merged

Conversation

@vcarel
Copy link
Contributor

vcarel commented Aug 10, 2018

Fixes #1126


This change is Reviewable

Copy link
Member

justin808 left a comment

see comments

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vcarel)


CHANGELOG.md, line 11 at r1 (raw file):

Changes since last non-beta release.

- Ignore Arrays in Rails i18n yml files

see formatting of other entries


lib/react_on_rails/locales_to_js.rb, line 110 at r1 (raw file):

        if v.is_a? Hash
          flatten(v).map { |hk, hv| h["#{k}.#{hk}".to_sym] = hv }
        elsif v.is_a? Array
elsif !v.is_a?(Array)
          # Arrays are not supported by react-intl
          h[k] = v.gsub("%{", "{")
@justin808

This comment has been minimized.

Copy link
Member

justin808 commented Aug 14, 2018

@vcarel any update?

@vcarel

This comment has been minimized.

Copy link
Contributor Author

vcarel commented Aug 16, 2018

@justin808 I'm on vacation for 2 weeks. I'll look into that when I'll be back in. Thx for your review.

@vcarel vcarel force-pushed the vcarel:fix/ignore-arrays-in-rails-i18n-yml-files branch from 397cf44 to d093f21 Sep 3, 2018
@vcarel

This comment has been minimized.

Copy link
Contributor Author

vcarel commented Sep 3, 2018

@justin808 I just did the update, sorry for the delay.

@justin808

This comment has been minimized.

Copy link
Member

justin808 commented Sep 3, 2018

@vcarel can you please rebase on top of master and ensure that CI passes.

@vcarel vcarel force-pushed the vcarel:fix/ignore-arrays-in-rails-i18n-yml-files branch from d093f21 to 1994c24 Sep 4, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage remained the same at ?% when pulling 1994c24 on vcarel:fix/ignore-arrays-in-rails-i18n-yml-files into c80f264 on shakacode:master.

@justin808 justin808 merged commit 89c2a7e into shakacode:master Sep 4, 2018
1 of 2 checks passed
1 of 2 checks passed
code-review/reviewable 3 files, 2 discussions left (justin808, vcarel)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@justin808

This comment has been minimized.

Copy link
Member

justin808 commented Sep 4, 2018

Thanks @vcarel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.