Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to render during interactive readyState #1152

Merged
merged 1 commit into from Oct 6, 2018

Conversation

@rakelley
Copy link
Contributor

rakelley commented Oct 3, 2018

This is a follow-up to PR 1151. I apologize for doubling up on this, but the last change was insufficient and we've found additional edge cases of undesired behavior with aggressive preloading of deferred scripts.

In addition to solving behavior for non-turbolinks users, this change also restores the original intent of clientStartup(), which explicitly calls out the turbolink check as needing to be done AFTER page load. Since PR 1099 this check has potentially been done prior to load.


This change is Reviewable

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 3, 2018

Coverage Status

Coverage remained the same at ?% when pulling 7bde2d1 on rakelley:init-event-handling into 3283f3d on shakacode:master.

Copy link
Member

justin808 left a comment

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@justin808 justin808 merged commit ad7cc2d into shakacode:master Oct 6, 2018
2 checks passed
2 checks passed
code-review/reviewable 2 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
justin808 referenced this pull request Oct 6, 2018
@justin808

This comment has been minimized.

Copy link
Member

justin808 commented Oct 6, 2018

I just released 11.0.6. 11.0.5 is broken.

@rakelley can you check that this comment is addressed. 46350ce#commitcomment-30794250

If there are more changes to this, I'll push another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.