Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodash to default dependencies #175

Merged
merged 1 commit into from Dec 31, 2015

Conversation

@justin808

This comment has been minimized.

Copy link
Member

justin808 commented Dec 30, 2015

@robwise How's this look to you?

@robwise

This comment has been minimized.

Copy link
Contributor

robwise commented Dec 30, 2015

@justin808 If we want to do the bindAll thing in the constructor, then yes this looks good to me. We can completely avoid this dependency and completely eliminate the entire constructor, however, simply by using an alternate method of binding, such as :: or making _handleChange a class property holding a fat arrow function.

justin808 added a commit that referenced this pull request Dec 31, 2015
Lodash to default dependencies
@justin808 justin808 merged commit a19a14a into shakacode:master Dec 31, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.345%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.