From 24dd92e297352914738ca4023798d1c77e02ed35 Mon Sep 17 00:00:00 2001 From: Abanoub Ghadban Date: Mon, 27 Oct 2025 17:42:58 +0300 Subject: [PATCH 1/2] run "link-source" script in development environment only at node renderer package don't run the "link-source" script on preinstall of the node renderer package when it's installed at a client project and not running in dev environment it depends on checking if yarn.lock file exist at installing directory to check if it's in dev environment --- react_on_rails_pro/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react_on_rails_pro/package.json b/react_on_rails_pro/package.json index be861fb2e9..659772644a 100644 --- a/react_on_rails_pro/package.json +++ b/react_on_rails_pro/package.json @@ -103,7 +103,7 @@ "packages/node-renderer/dist" ], "scripts": { - "preinstall": "yarn run link-source && yalc add --link react-on-rails", + "preinstall": "(test -f yarn.lock && yarn run link-source && yalc add --link react-on-rails) || true", "postinstall": "test -f post-yarn-install.local && ./post-yarn-install.local || true", "link-source": "cd ../packages/react-on-rails && yarn && yalc publish", "test": "nps test", From babd4770b3373a0de62414373f6be9d84f38b8fd Mon Sep 17 00:00:00 2001 From: Abanoub Ghadban Date: Mon, 27 Oct 2025 18:07:03 +0300 Subject: [PATCH 2/2] don't silently ignore the error at link-source script when called --- react_on_rails_pro/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react_on_rails_pro/package.json b/react_on_rails_pro/package.json index 659772644a..efefb2bfc5 100644 --- a/react_on_rails_pro/package.json +++ b/react_on_rails_pro/package.json @@ -103,7 +103,7 @@ "packages/node-renderer/dist" ], "scripts": { - "preinstall": "(test -f yarn.lock && yarn run link-source && yalc add --link react-on-rails) || true", + "preinstall": "test -f yarn.lock || exit 0; yarn run link-source && yalc add --link react-on-rails", "postinstall": "test -f post-yarn-install.local && ./post-yarn-install.local || true", "link-source": "cd ../packages/react-on-rails && yarn && yalc publish", "test": "nps test",