From fdcb81ddc99004d028c08e061ebc85d02356cad2 Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Sat, 15 Nov 2025 20:23:27 -1000 Subject: [PATCH] Fix bin/dev --verbose option causing error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The --verbose flag was documented in bin/dev --help but not implemented in the OptionParser, causing an error when used. This fix: - Adds verbose: false to the options hash - Implements --verbose/-v flag parsing in OptionParser - Updates all start() calls to use options[:verbose] instead of hardcoded false - Adds RuboCop disable comment for increased AbcSize metric Closes #1849 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- lib/react_on_rails/dev/server_manager.rb | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/react_on_rails/dev/server_manager.rb b/lib/react_on_rails/dev/server_manager.rb index 64d0cdea17..e1ff3e0825 100644 --- a/lib/react_on_rails/dev/server_manager.rb +++ b/lib/react_on_rails/dev/server_manager.rb @@ -144,10 +144,11 @@ def show_help puts help_troubleshooting end + # rubocop:disable Metrics/AbcSize def run_from_command_line(args = ARGV) require "optparse" - options = { route: nil, rails_env: nil } + options = { route: nil, rails_env: nil, verbose: false } OptionParser.new do |opts| opts.banner = "Usage: dev [command] [options]" @@ -160,6 +161,10 @@ def run_from_command_line(args = ARGV) options[:rails_env] = env end + opts.on("-v", "--verbose", "Enable verbose output for pack generation") do + options[:verbose] = true + end + opts.on("-h", "--help", "Prints this help") do show_help exit @@ -172,21 +177,23 @@ def run_from_command_line(args = ARGV) # Main execution case command when "production-assets", "prod" - start(:production_like, nil, verbose: false, route: options[:route], rails_env: options[:rails_env]) + start(:production_like, nil, verbose: options[:verbose], route: options[:route], + rails_env: options[:rails_env]) when "static" - start(:static, "Procfile.dev-static-assets", verbose: false, route: options[:route]) + start(:static, "Procfile.dev-static-assets", verbose: options[:verbose], route: options[:route]) when "kill" kill_processes when "help", "--help", "-h" show_help when "hmr", nil - start(:development, "Procfile.dev", verbose: false, route: options[:route]) + start(:development, "Procfile.dev", verbose: options[:verbose], route: options[:route]) else puts "Unknown argument: #{command}" puts "Run 'dev help' for usage information" exit 1 end end + # rubocop:enable Metrics/AbcSize private