From 0dc54324b3b906345f5988c9f6fb3ca1f56e559d Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Thu, 20 Nov 2025 10:04:19 -1000 Subject: [PATCH] Fix ci-changes-detector to recognize Pro package test files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Root Cause: The ci-changes-detector script was missing patterns for test files in the Pro package. When PR #2074 changed only `packages/react-on-rails-pro/tests/testUtils.ts`, the detector incorrectly classified it as a docs-only change because the pattern only matched `packages/react-on-rails-pro/src/**/*`. This triggered the ensure-master-docs-safety action, which correctly failed the workflow since the previous commit had test failures. The safety mechanism worked as intended, but the root cause was the missing pattern. Changes: - Add patterns for `packages/react-on-rails/tests/**/*` to trigger JS tests - Add patterns for `packages/react-on-rails-pro/tests/**/*` to trigger Pro tests - Add patterns for `scripts/`, `package.json`, and `tsconfig.json` in both packages - Update comments to clarify what's included in each pattern Impact: - Pro and open-source package test file changes will now correctly trigger CI - Package configuration changes will trigger appropriate test suites - Prevents false-positive "docs-only" detection that blocks deployments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- script/ci-changes-detector | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/script/ci-changes-detector b/script/ci-changes-detector index e575d6d20d..3a4bfd53c7 100755 --- a/script/ci-changes-detector +++ b/script/ci-changes-detector @@ -91,8 +91,8 @@ while IFS= read -r file; do GENERATORS_CHANGED=true ;; - # JavaScript/TypeScript source - package.json|yarn.lock|packages/react-on-rails/src/*|packages/react-on-rails/src/**/*|.github/workflows/package-js-tests.yml) + # JavaScript/TypeScript source (including tests, scripts, and package files) + package.json|yarn.lock|packages/react-on-rails/src/*|packages/react-on-rails/src/**/*|packages/react-on-rails/tests/*|packages/react-on-rails/tests/**/*|packages/react-on-rails/scripts/*|packages/react-on-rails/scripts/**/*|packages/react-on-rails/package.json|packages/react-on-rails/tsconfig.json|.github/workflows/package-js-tests.yml) DOCS_ONLY=false JS_CHANGED=true ;; @@ -109,8 +109,8 @@ while IFS= read -r file; do PRO_RUBY_CHANGED=true ;; - # JavaScript/TypeScript Pro source - packages/react-on-rails-pro/src/*|packages/react-on-rails-pro/src/**/*) + # JavaScript/TypeScript Pro source (including tests, scripts, and package files) + packages/react-on-rails-pro/src/*|packages/react-on-rails-pro/src/**/*|packages/react-on-rails-pro/tests/*|packages/react-on-rails-pro/tests/**/*|packages/react-on-rails-pro/scripts/*|packages/react-on-rails-pro/scripts/**/*|packages/react-on-rails-pro/package.json|packages/react-on-rails-pro/tsconfig.json) DOCS_ONLY=false PRO_JS_CHANGED=true ;;