Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failure to sanitize console messages #366

Merged
merged 1 commit into from Apr 4, 2016

Conversation

@justin808
Copy link
Member

justin808 commented Apr 4, 2016

  • Only happened with server rendering.
  • Fix is to escape for closing script tag

This change is Reviewable

* Only happened with server rendering.
* Fix is to escape for closing script tag
@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Apr 4, 2016

@descentintomael, any chance that you can take a quick look at this.

@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Apr 4, 2016

@alexfedoseev @samnang Good enough to just escape the closing </script> tag?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 4, 2016

Coverage Status

Coverage remained the same at 87.396% when pulling 2cafba2 on fix-sanitization-server-console-messages into da9d525 on master.

@justin808 justin808 merged commit 791e3cc into master Apr 4, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.396%
Details
@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Apr 4, 2016

I'm going to release this one without review. However, I'd like to get this one still reviewed!

@robwise robwise deleted the fix-sanitization-server-console-messages branch Apr 5, 2016
@justin808

This comment has been minimized.

Copy link
Member Author

justin808 commented Apr 5, 2016

Looks like I need to do this: http://stackoverflow.com/a/23983448/1009332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.